added roles and organizations
tests / ci (push) Canceled after 0s

This commit is contained in:
2026-10-15 20:59:32 -07:00
parent 2ca3860557
commit 177f122c10
57 changed files with 6378 additions and 247 deletions
+103
View File
@@ -1,6 +1,8 @@
<?php
use App\Models\Organization;
use App\Models\User;
use App\OrganizationRole;
use Livewire\Livewire;
test('guests are redirected from the notes limits page', function () {
@@ -15,6 +17,34 @@ test('non-admins cannot access the notes limits page', function () {
$this->get(route('admin.notes-limits'))->assertForbidden();
});
test('workspace admins are not site admins and cannot access the notes limits page', function () {
$workspaceAdmin = User::factory()->create();
$organization = Organization::factory()->family()
->withMember($workspaceAdmin, OrganizationRole::Admin)
->create();
$this->actingAs($workspaceAdmin);
expect($organization->userHasRole($workspaceAdmin, OrganizationRole::Admin))->toBeTrue();
$this->get(route('admin.notes-limits'))->assertForbidden();
});
test('a non-admin cannot save a notes limit through a direct action call', function () {
$admin = User::factory()->asAdmin()->create();
$this->actingAs($admin);
$member = User::factory()->create();
$component = Livewire::test('pages::admin.notes-limits')->call('startEditLimit', $member->id);
$this->actingAs($member);
$component->set('notesLimitInput', '2500')->call('saveNotesLimit')->assertForbidden();
expect($member->fresh()->notes_limit)->toBe(1000);
});
test('non-admins do not see the notes limits navigation item', function () {
$user = User::factory()->create();
$this->actingAs($user);
@@ -33,6 +63,36 @@ test('admins see the notes limits navigation item', function () {
->assertSee('Notes limits');
});
test('site admins see the site admin navigation group', function () {
$user = User::factory()->asAdmin()->create();
$this->actingAs($user);
$this->get(route('dashboard'))
->assertOk()
->assertSee('Site admin');
});
test('workspace admins do not see the site admin navigation group', function () {
$workspaceAdmin = User::factory()->create();
Organization::factory()->family()
->withMember($workspaceAdmin, OrganizationRole::Admin)
->create();
$this->actingAs($workspaceAdmin);
$this->get(route('dashboard'))
->assertOk()
->assertDontSee('Site admin');
});
test('the notes limits page identifies site administrators', function () {
$admin = User::factory()->asAdmin()->create();
$this->actingAs($admin);
Livewire::test('pages::admin.notes-limits')
->assertSee('Site admin');
});
test('admins can view the notes limits page', function () {
$user = User::factory()->asAdmin()->create();
$this->actingAs($user);
@@ -70,3 +130,46 @@ test('a notes limit must be a valid positive number', function () {
expect($member->fresh()->notes_limit)->toBe(1000);
});
test('admins can search users by name or email', function () {
$admin = User::factory()->asAdmin()->create();
$this->actingAs($admin);
$match = User::factory()->create(['name' => 'Ada Lovelace', 'email' => 'ada@example.com']);
$emailMatch = User::factory()->create(['name' => 'Grace Hopper', 'email' => 'grace@searchable.test']);
$other = User::factory()->create(['name' => 'Alan Turing', 'email' => 'alan@example.com']);
Livewire::test('pages::admin.notes-limits')
->set('search', 'lovelace')
->assertSee('Ada Lovelace')
->assertDontSee('Alan Turing')
->set('search', 'searchable.test')
->assertSee('Grace Hopper')
->assertDontSee($match->name)
->assertDontSee($other->name);
});
test('searching resets the page', function () {
$admin = User::factory()->asAdmin()->create();
$this->actingAs($admin);
User::factory()->count(11)->create();
Livewire::test('pages::admin.notes-limits')
->call('gotoPage', 2)
->assertSet('paginators.page', 2)
->set('search', 'anything')
->assertSet('paginators.page', 1);
});
test('the notes limits list is paginated', function () {
$admin = User::factory()->asAdmin()->create();
$this->actingAs($admin);
User::factory()->count(12)->create();
$component = Livewire::test('pages::admin.notes-limits');
expect($component->instance()->users->perPage())->toBe(10)
->and($component->instance()->users->total())->toBe(13);
});
+1 -1
View File
@@ -13,7 +13,7 @@ test('base data includes a default admin user', function () {
expect($admin)->not->toBeNull()
->and($admin->name)->toBe('Administrator')
->and($admin->notes_limit)->toBe(1000);
$this->assertTrue($admin->isAdmin());
$this->assertTrue($admin->isSiteAdmin());
});
test('base data seeding is idempotent', function () {
+33
View File
@@ -3,6 +3,7 @@
use App\Models\Organization;
use App\Models\Setting;
use App\Models\User;
use App\OrganizationRole;
use Livewire\Livewire;
test('guests are redirected from the plan pricing page', function () {
@@ -16,6 +17,38 @@ test('non-admins cannot access the plan pricing page', function () {
$this->get(route('admin.plan-pricing'))->assertForbidden();
});
test('workspace admins are not site admins and cannot access the plan pricing page', function () {
$workspaceAdmin = User::factory()->create();
$organization = Organization::factory()->family()
->withMember($workspaceAdmin, OrganizationRole::Admin)
->create();
$this->actingAs($workspaceAdmin);
expect($organization->userHasRole($workspaceAdmin, OrganizationRole::Admin))->toBeTrue();
$this->get(route('admin.plan-pricing'))->assertForbidden();
});
test('a non-admin cannot save plan amounts through a direct action call', function () {
config()->set('plans.plans', [
'pro' => ['name' => 'Pro', 'price' => 'price_pro', 'interval' => 'month'],
]);
$admin = User::factory()->asAdmin()->create();
$this->actingAs($admin);
$member = User::factory()->create();
$component = Livewire::test('pages::admin.plan-pricing');
$this->actingAs($member);
$component->set('amounts.pro', '99.00')->call('saveAmounts')->assertForbidden();
expect(Organization::planAmount('pro'))->toBe(1000);
});
test('non-admins do not see the plan pricing navigation item', function () {
$this->actingAs(User::factory()->create());
+276
View File
@@ -0,0 +1,276 @@
<?php
use App\FolderRole;
use App\FolderVisibility;
use App\Models\Folder;
use App\Models\Organization;
use App\Models\Todo;
use App\Models\User;
use App\OrganizationRole;
function familyWorkspace(User $owner): Organization
{
$org = Organization::factory()->family()->withMember($owner)->create();
$owner->forceFill(['current_organization_id' => $org->id])->save();
return $org;
}
function addWorkspaceMember(Organization $org, User $user, OrganizationRole $role = OrganizationRole::Member): void
{
$org->users()->attach($user, ['role' => $role->value]);
}
test('the folder creating hook assigns the owner workspace and personal folders stay private', function () {
$user = User::factory()->create();
$folder = Folder::factory()->for($user)->create(['name' => 'Personal Project']);
expect($folder->organization_id)->toBe($user->current_organization_id);
expect($folder->visibility)->toBe(FolderVisibility::Private);
});
test('folders in a family workspace default to workspace visibility', function () {
$owner = User::factory()->create();
familyWorkspace($owner);
$folder = Folder::factory()->for($owner)->create(['name' => 'Shared List']);
expect($folder->organization_id)->toBe($owner->current_organization_id);
expect($folder->visibility)->toBe(FolderVisibility::Workspace);
});
test('the todo creating hook inherits the workspace of its folder', function () {
$user = User::factory()->create();
$folder = Folder::factory()->for($user)->create(['name' => 'Work']);
$todo = Todo::factory()->for($folder)->create(['description' => 'A task']);
expect($todo->organization_id)->toBe($folder->organization_id);
});
test('the folder owner holds admin on their own folder', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Mine']);
expect($folder->effectiveRoleFor($owner))->toBe(FolderRole::Admin);
});
test('a workspace member sees workspace folders as a viewer', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
expect($folder->effectiveRoleFor($member))->toBe(FolderRole::Viewer);
});
test('a workspace admin holds admin on workspace folders', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$admin = User::factory()->create();
addWorkspaceMember($org, $admin, OrganizationRole::Admin);
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
expect($folder->effectiveRoleFor($admin))->toBe(FolderRole::Admin);
});
test('an explicit share grants the shared role on a private folder', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Private']);
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
expect($folder->effectiveRoleFor($member))->toBe(FolderRole::Editor);
});
test('the strongest of overlapping roles wins', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
expect($folder->effectiveRoleFor($member))->toBe(FolderRole::Editor);
});
test('a workspace member cannot access a private folder', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Private']);
expect($folder->effectiveRoleFor($member))->toBeNull();
});
test('a share on a parent folder cascades to its descendants', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$parent = Folder::factory()->for($owner)->private()->create(['name' => 'Parent']);
$child = Folder::factory()->childOf($parent)->private()->create(['name' => 'Child']);
$parent->shares()->attach($member, ['role' => FolderRole::Editor->value]);
expect($parent->effectiveRoleFor($member))->toBe(FolderRole::Editor);
expect($child->effectiveRoleFor($member))->toBe(FolderRole::Editor);
});
test('a private folder drops out of inherited workspace access', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$parent = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Parent']);
$child = Folder::factory()->childOf($parent)->private()->create(['name' => 'Private Child']);
expect($parent->effectiveRoleFor($member))->toBe(FolderRole::Viewer);
expect($child->effectiveRoleFor($member))->toBeNull();
});
test('the visibleTo scope covers workspace folders and excludes strangers', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$stranger = User::factory()->create();
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
expect(Folder::query()->visibleTo($member)->pluck('id'))->toContain($folder->id);
expect(Folder::query()->visibleTo($stranger)->pluck('id'))->not->toContain($folder->id);
});
test('the visibleTo scope includes folders shared with the user anywhere', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Shared With Me']);
$stranger = User::factory()->create();
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
expect(Folder::query()->visibleTo($member)->pluck('id'))->toContain($folder->id);
expect(Folder::query()->visibleTo($stranger)->pluck('id'))->not->toContain($folder->id);
});
test('todo visibility follows the folder access', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$stranger = User::factory()->create();
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
$todo = Todo::factory()->for($folder)->create(['description' => 'Shared task']);
expect(Todo::query()->visibleTo($member)->pluck('id'))->toContain($todo->id);
expect(Todo::query()->visibleTo($stranger)->pluck('id'))->not->toContain($todo->id);
});
test('workspace members can view workspace folders', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
$this->actingAs($member);
expect($member->can('view', $folder))->toBeTrue();
});
test('strangers cannot view folders they have no role on', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Private']);
$stranger = User::factory()->create();
$this->actingAs($stranger);
expect($stranger->can('view', $folder))->toBeFalse();
});
test('viewers cannot rename a folder', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
$this->actingAs($member);
expect($member->can('update', $folder))->toBeFalse();
});
test('a folder admin can share a folder and create folders beneath it', function () {
$owner = User::factory()->create();
$admin = User::factory()->create();
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Dir']);
$folder->shares()->attach($admin, ['role' => FolderRole::Admin->value]);
$this->actingAs($admin);
expect($admin->can('manageShares', $folder))->toBeTrue();
expect($admin->can('createChild', $folder))->toBeTrue();
});
test('only workspace admins create top-level folders', function () {
$owner = User::factory()->create();
$org = familyWorkspace($owner);
$member = User::factory()->create();
addWorkspaceMember($org, $member);
$workspaceAdmin = User::factory()->create();
addWorkspaceMember($org, $workspaceAdmin, OrganizationRole::Admin);
$this->actingAs($member);
expect($member->can('create', [Folder::class, $org]))->toBeFalse();
$this->actingAs($workspaceAdmin);
expect($workspaceAdmin->can('create', [Folder::class, $org]))->toBeTrue();
});
test('editors can add and edit todos while markers only mark complete', function () {
$owner = User::factory()->create();
$editor = User::factory()->create();
$marker = User::factory()->create();
$viewer = User::factory()->create();
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Dir']);
$folder->shares()->attach($editor, ['role' => FolderRole::Editor->value]);
$folder->shares()->attach($marker, ['role' => FolderRole::Marker->value]);
$folder->shares()->attach($viewer, ['role' => FolderRole::Viewer->value]);
$todo = Todo::factory()->for($folder)->create(['description' => 'A task']);
$this->actingAs($editor);
expect($editor->can('create', [Todo::class, $folder]))->toBeTrue();
expect($editor->can('update', $todo))->toBeTrue();
$this->actingAs($marker);
expect($marker->can('create', [Todo::class, $folder]))->toBeFalse();
expect($marker->can('update', $todo))->toBeFalse();
expect($marker->can('markComplete', $todo))->toBeTrue();
$this->actingAs($viewer);
expect($viewer->can('markComplete', $todo))->toBeFalse();
});
test('strangers cannot touch todos in a folder', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Dir']);
$todo = Todo::factory()->for($folder)->create(['description' => 'A task']);
$stranger = User::factory()->create();
$this->actingAs($stranger);
expect($stranger->can('view', $todo))->toBeFalse();
expect($stranger->can('update', $todo))->toBeFalse();
expect($stranger->can('delete', $todo))->toBeFalse();
expect($stranger->can('markComplete', $todo))->toBeFalse();
});
+137
View File
@@ -0,0 +1,137 @@
<?php
use App\FolderRole;
use App\FolderVisibility;
use App\Mail\InvitationMail;
use App\Models\Folder;
use App\Models\Invitation;
use App\Models\Organization;
use App\Models\User;
use App\OrganizationRole;
use Illuminate\Support\Facades\Mail;
use Livewire\Livewire;
/**
* Create a family workspace owned by the given user and make it their active
* workspace, which is what the folders page scopes to.
*/
function familyWorkspaceFor(User $owner): Organization
{
$organization = Organization::factory()->family()->withMember($owner)->create();
$owner->forceFill(['current_organization_id' => $organization->id])->save();
return $organization;
}
test('a folder admin can invite a collaborator by email', function () {
Mail::fake();
$owner = User::factory()->create();
$organization = familyWorkspaceFor($owner);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->create(['name' => 'Dir']);
$this->actingAs($owner);
Livewire::test('pages::folders')
->call('startShare', $folder->id)
->set('inviteEmail', 'New.Person@example.com')
->set('inviteRole', FolderRole::Editor->value)
->call('inviteCollaborator')
->assertHasNoErrors();
$this->assertDatabaseHas('invitations', [
'inviteable_type' => Folder::class,
'inviteable_id' => $folder->id,
'email' => 'new.person@example.com',
'role' => FolderRole::Editor->value,
]);
Mail::assertSent(InvitationMail::class);
});
test('inviting someone who already has access is rejected', function () {
Mail::fake();
$owner = User::factory()->create();
$organization = familyWorkspaceFor($owner);
$collaborator = User::factory()->create();
$folder = Folder::factory()->for($owner)->inOrganization($organization)->create(['name' => 'Dir']);
$folder->shares()->attach($collaborator, ['role' => FolderRole::Editor->value]);
$this->actingAs($owner);
Livewire::test('pages::folders')
->call('startShare', $folder->id)
->set('inviteEmail', $collaborator->email)
->call('inviteCollaborator')
->assertHasErrors('inviteEmail');
Mail::assertNothingSent();
});
test('a folder admin can change and remove a collaborator', function () {
$owner = User::factory()->create();
$organization = familyWorkspaceFor($owner);
$collaborator = User::factory()->create();
$folder = Folder::factory()->for($owner)->inOrganization($organization)->create(['name' => 'Dir']);
$folder->shares()->attach($collaborator, ['role' => FolderRole::Editor->value]);
$this->actingAs($owner);
Livewire::test('pages::folders')
->call('startShare', $folder->id)
->set('collaboratorRoles.'.$collaborator->id, FolderRole::Viewer->value)
->assertHasNoErrors();
expect($folder->sharedRoleFor($collaborator))->toBe(FolderRole::Viewer);
Livewire::test('pages::folders')
->call('startShare', $folder->id)
->call('removeCollaborator', $collaborator->id);
expect($folder->sharedRoleFor($collaborator))->toBeNull();
});
test('a folder admin can share a folder with the whole workspace', function () {
$owner = User::factory()->create();
$organization = familyWorkspaceFor($owner);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->private()->create(['name' => 'Dir']);
$this->actingAs($owner);
Livewire::test('pages::folders')
->call('startShare', $folder->id)
->set('shareVisibility', FolderVisibility::Workspace->value)
->assertHasNoErrors();
expect($folder->fresh()->visibility)->toBe(FolderVisibility::Workspace);
});
test('a folder admin can revoke a pending invitation', function () {
$owner = User::factory()->create();
$organization = familyWorkspaceFor($owner);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->create(['name' => 'Dir']);
$invitation = Invitation::factory()->forFolder($folder)->create(['inviter_id' => $owner->id]);
$this->actingAs($owner);
Livewire::test('pages::folders')
->call('startShare', $folder->id)
->call('revokeFolderInvitation', $invitation->id);
$this->assertDatabaseMissing('invitations', ['id' => $invitation->id]);
});
test('a non-admin cannot open the share panel', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = familyWorkspaceFor($owner);
$organization->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$member->forceFill(['current_organization_id' => $organization->id])->save();
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Dir']);
$this->actingAs($member);
Livewire::test('pages::folders')->call('startShare', $folder->id)->assertStatus(403);
});
+19
View File
@@ -334,6 +334,25 @@ test('users cannot move a todo to another user folder', function () {
->call('moveTodoToFolder', $todo->id, $foreign->id);
});
test('the folder tree knows which workspace each folder belongs to', function () {
$user = User::factory()->create();
$work = Folder::factory()->for($user)->create(['name' => 'Work']);
$node = Folder::treeForUser($user)->first()['folder'];
expect($node->organization?->name)->toBe($user->currentOrganization()->first()->name);
});
test('folders show which workspace they belong to', function () {
$user = User::factory()->create();
$work = Folder::factory()->for($user)->create(['name' => 'Work']);
$this->actingAs($user);
Livewire::test('pages::folders')
->assertSee($user->currentOrganization()->first()->name)
->assertSeeHtml('data-test="folder-workspace-'.$work->id.'"', false);
});
test('users cannot move another user todo', function () {
$owner = User::factory()->create();
$ownerFolder = Folder::factory()->for($owner)->create(['name' => 'Owner Folder']);
+103
View File
@@ -0,0 +1,103 @@
<?php
use App\FolderRole;
use App\Models\Folder;
use App\Models\Invitation;
use App\Models\Organization;
use App\Models\User;
use App\OrganizationRole;
use Livewire\Livewire;
test('guests are redirected to login before they can accept', function () {
$invitation = Invitation::factory()->create();
$this->get(route('invitations.accept', $invitation->token))
->assertRedirect(route('login'));
});
test('an authenticated invitee can load the accept page through its token', function () {
$invitation = Invitation::factory()->create();
$this->actingAs(User::factory()->create())
->get(route('invitations.accept', $invitation->token))
->assertOk()
->assertSee('Accept invitation');
});
test('an authenticated user can accept a folder invitation', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forFolder($folder, FolderRole::Editor)->create();
$this->actingAs($invitee);
Livewire::test('pages::invitations.accept', ['invitation' => $invitation])
->call('accept')
->assertRedirect(route('dashboard'));
expect($folder->sharedRoleFor($invitee))->toBe(FolderRole::Editor);
});
test('an authenticated user can accept a workspace invitation', function () {
$owner = User::factory()->create();
$organization = Organization::factory()->family()->withMember($owner)->create();
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forOrganization($organization)->create();
$this->actingAs($invitee);
Livewire::test('pages::invitations.accept', ['invitation' => $invitation])
->call('accept')
->assertRedirect(route('dashboard'));
expect($organization->users()->where('users.id', $invitee->id)->exists())->toBeTrue();
expect($invitee->fresh()->current_organization_id)->toBe($organization->id);
});
test('a full workspace refuses a workspace invitation', function () {
$owner = User::factory()->create();
$organization = Organization::factory()->family()->withMember($owner)->create();
for ($i = 0; $i < 5; $i++) {
$organization->users()->attach(User::factory()->create(), ['role' => OrganizationRole::Member->value]);
}
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forOrganization($organization)->create();
$this->actingAs($invitee);
Livewire::test('pages::invitations.accept', ['invitation' => $invitation])
->call('accept')
->assertHasErrors('invitation');
expect($organization->users()->where('users.id', $invitee->id)->exists())->toBeFalse();
});
test('an accepted invitation shows its accepted state and grants nothing new', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forFolder($folder)->accepted()->create();
$this->actingAs($invitee);
Livewire::test('pages::invitations.accept', ['invitation' => $invitation])
->assertSeeHtml('data-test="invitation-accepted"')
->call('accept');
expect($folder->sharedRoleFor($invitee))->toBeNull();
});
test('an expired invitation shows its expired state', function () {
$invitation = Invitation::factory()->expired()->create();
$invitee = User::factory()->create();
$this->actingAs($invitee);
Livewire::test('pages::invitations.accept', ['invitation' => $invitation])
->assertSeeHtml('data-test="invitation-expired"');
});
+177
View File
@@ -0,0 +1,177 @@
<?php
use App\FolderRole;
use App\Mail\InvitationMail;
use App\Models\Folder;
use App\Models\Invitation;
use App\Models\Organization;
use App\Models\User;
use App\OrganizationRole;
test('a folder invitation resolves its inviteable and stays valid', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$invitation = Invitation::factory()->forFolder($folder, FolderRole::Editor)->create();
expect($invitation->inviteable()->first())->toBeInstanceOf(Folder::class);
expect($invitation->inviteable->is($folder))->toBeTrue();
expect($invitation->role)->toBe(FolderRole::Editor->value);
expect($invitation->isValid())->toBeTrue();
});
test('a workspace invitation resolves its inviteable and stays valid', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
$invitation = Invitation::factory()->forOrganization($org, OrganizationRole::Member->value)->create();
expect($invitation->inviteable->is($org))->toBeTrue();
expect($invitation->isValid())->toBeTrue();
});
test('an invitation that has been redeemed is no longer valid', function () {
$invitation = Invitation::factory()->accepted()->create();
expect($invitation->isAccepted())->toBeTrue();
expect($invitation->isValid())->toBeFalse();
});
test('an invitation that has lapsed is no longer valid', function () {
$invitation = Invitation::factory()->expired()->create();
expect($invitation->isExpired())->toBeTrue();
expect($invitation->isValid())->toBeFalse();
});
test('an invitation token is unique', function () {
$invitation = Invitation::factory()->create();
expect(Invitation::query()->where('token', $invitation->token)->count())->toBe(1);
});
test('only folder admins can invite people into a folder', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$editor = User::factory()->create();
$folder->shares()->attach($editor, ['role' => FolderRole::Editor->value]);
$admin = User::factory()->create();
$folder->shares()->attach($admin, ['role' => FolderRole::Admin->value]);
$this->actingAs($editor);
expect($editor->can('create', [Invitation::class, $folder]))->toBeFalse();
$this->actingAs($admin);
expect($admin->can('create', [Invitation::class, $folder]))->toBeTrue();
});
test('only workspace admins can invite people into a workspace', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
$member = User::factory()->create();
$org->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$admin = User::factory()->create();
$org->users()->attach($admin, ['role' => OrganizationRole::Admin->value]);
$this->actingAs($member);
expect($member->can('create', [Invitation::class, $org]))->toBeFalse();
$this->actingAs($admin);
expect($admin->can('create', [Invitation::class, $org]))->toBeTrue();
});
test('an invitation can be revoked by its sender or a folder admin', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$inviter = User::factory()->create();
$invitation = Invitation::factory()->forFolder($folder)->create(['inviter_id' => $inviter->id]);
$stranger = User::factory()->create();
$this->actingAs($stranger);
expect($stranger->can('delete', $invitation))->toBeFalse();
$this->actingAs($inviter);
expect($inviter->can('delete', $invitation))->toBeTrue();
});
test('the pending scope omits accepted and expired invitations', function () {
Invitation::factory()->create();
Invitation::factory()->accepted()->create();
Invitation::factory()->expired()->create();
expect(Invitation::query()->pending()->count())->toBe(1);
});
test('the role helpers reflect the kind of inviteable', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$folderInvitation = Invitation::factory()->forFolder($folder, FolderRole::Marker)->create();
expect($folderInvitation->isForFolder())->toBeTrue();
expect($folderInvitation->isForWorkspace())->toBeFalse();
expect($folderInvitation->folderRole())->toBe(FolderRole::Marker);
expect($folderInvitation->organizationRole())->toBeNull();
expect($folderInvitation->roleLabel())->toBe('Marker');
$organization = Organization::factory()->family()->withMember($owner)->create();
$workspaceInvitation = Invitation::factory()->forOrganization($organization, OrganizationRole::Admin->value)->create();
expect($workspaceInvitation->isForWorkspace())->toBeTrue();
expect($workspaceInvitation->organizationRole())->toBe(OrganizationRole::Admin);
expect($workspaceInvitation->folderRole())->toBeNull();
expect($workspaceInvitation->roleLabel())->toBe('Admin');
});
test('accepting a folder invitation grants the shared role and records the acceptor', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forFolder($folder, FolderRole::Editor)->create();
$invitation->accept($invitee);
expect($folder->sharedRoleFor($invitee))->toBe(FolderRole::Editor);
expect($invitation->fresh()->isAccepted())->toBeTrue();
expect($invitation->fresh()->accepted_by_id)->toBe($invitee->id);
});
test('accepting a workspace invitation adds the member and switches their active workspace', function () {
$owner = User::factory()->create();
$organization = Organization::factory()->family()->withMember($owner)->create();
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forOrganization($organization)->create();
$invitation->accept($invitee);
expect($organization->users()->where('users.id', $invitee->id)->exists())->toBeTrue();
expect($invitee->fresh()->current_organization_id)->toBe($organization->id);
});
test('an expired invitation cannot be accepted', function () {
$owner = User::factory()->create();
$folder = Folder::factory()->for($owner)->create(['name' => 'Dir']);
$invitee = User::factory()->create();
$invitation = Invitation::factory()->forFolder($folder)->expired()->create();
$invitation->accept($invitee);
expect($folder->sharedRoleFor($invitee))->toBeNull();
expect($invitation->fresh()->accepted_at)->toBeNull();
});
test('the invitation mail links to the accept page with the invite details', function () {
$owner = User::factory()->create(['name' => 'Ada Owner']);
$folder = Folder::factory()->for($owner)->create(['name' => 'Shared Dir']);
$invitation = Invitation::factory()->forFolder($folder, FolderRole::Editor)->create(['inviter_id' => $owner->id]);
$rendered = (new InvitationMail($invitation))->render();
expect($rendered)->toContain('Shared Dir');
expect($rendered)->toContain('Ada Owner');
expect($rendered)->toContain(route('invitations.accept', $invitation->token));
});
+180
View File
@@ -0,0 +1,180 @@
<?php
use App\FolderRole;
use App\Models\Folder;
use App\Models\Organization;
use App\Models\Todo;
use App\Models\User;
use App\OrganizationRole;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Livewire\Livewire;
/**
* Add a member to a fresh family workspace and make it the active workspace
* for both users, so the pages (which scope to the active workspace) show the
* folders the workspace shares.
*/
function sharedWorkspace(User $owner, ?User $member = null, OrganizationRole $role = OrganizationRole::Member): Organization
{
$organization = Organization::factory()->family()->withMember($owner)->create();
$owner->forceFill(['current_organization_id' => $organization->id])->save();
if ($member !== null) {
$organization->users()->attach($member, ['role' => $role->value]);
$member->forceFill(['current_organization_id' => $organization->id])->save();
}
return $organization;
}
test('a workspace member sees a workspace folder on the folders page', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$this->actingAs($member);
Livewire::test('pages::folders')
->assertSee('Shared List')
->assertSeeHtml('data-test="folder-row-'.$folder->id.'"');
});
test('a workspace member sees workspace todos on the todos page and dashboard', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$todo = Todo::factory()->recycle($owner)->for($folder)->create(['description' => 'Shared task']);
$this->actingAs($member);
Livewire::test('pages::todos')
->assertSee('Shared task')
->assertSeeHtml('data-test="todo-description-'.$todo->id.'"');
Livewire::test('pages::dashboard')
->assertSee('Shared task')
->assertSet('todoCounts.open', 1);
});
test('a workspace member cannot access another members private folders', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
Folder::factory()->for($owner)->inOrganization($organization)->private()->create(['name' => 'Owner Private']);
$this->actingAs($member);
Livewire::test('pages::folders')->assertDontSee('Owner Private');
});
test('a viewer can see a shared folder but not manage it', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$this->actingAs($member);
Livewire::test('pages::folders')
->assertSeeHtml('data-test="view-todos-'.$folder->id.'"')
->assertDontSeeHtml('data-test="rename-folder-'.$folder->id.'"')
->assertDontSeeHtml('data-test="delete-folder-'.$folder->id.'"')
->assertDontSeeHtml('data-test="add-child-'.$folder->id.'"')
->assertDontSeeHtml('data-test="add-todo-'.$folder->id.'"');
Livewire::test('pages::folders')
->call('startRename', $folder->id)
->assertStatus(403);
});
test('an editor can create and complete todos in a shared folder', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
$this->actingAs($member);
Livewire::test('pages::todos')
->call('openCreateForm')
->set('description', 'Member task')
->set('formFolderId', $folder->id)
->call('saveTodo')
->assertHasNoErrors();
$this->assertDatabaseHas('todos', [
'user_id' => $member->id,
'folder_id' => $folder->id,
'description' => 'Member task',
]);
$todo = Todo::where('description', 'Member task')->firstOrFail();
Livewire::test('pages::todos')
->call('toggleComplete', $todo->id);
expect($todo->fresh()->completed_at)->not->toBeNull();
});
test('a viewer cannot create todos in a shared folder', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$this->actingAs($member);
Livewire::test('pages::todos')
->call('openCreateForm')
->set('description', 'Snooping')
->set('formFolderId', $folder->id)
->call('saveTodo')
->assertStatus(403);
$this->assertDatabaseCount('todos', 0);
});
test('a stranger cannot see or manage another workspace folders', function () {
$owner = User::factory()->create();
$organization = sharedWorkspace($owner);
$folder = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$stranger = User::factory()->create();
$this->actingAs($stranger);
Livewire::test('pages::folders')->assertDontSee('Shared List');
expect(fn () => Livewire::test('pages::folders')->call('startRename', $folder->id))
->toThrow(ModelNotFoundException::class);
});
test('a member cannot move a shared todo into a folder they cannot edit', function () {
$owner = User::factory()->create();
$member = User::factory()->create();
$organization = sharedWorkspace($owner, $member);
$shared = Folder::factory()->for($owner)->inOrganization($organization)->sharedWithWorkspace()->create(['name' => 'Shared List']);
$shared->shares()->attach($member, ['role' => FolderRole::Editor->value]);
$privateTarget = Folder::factory()->for($owner)->inOrganization($organization)->private()->create(['name' => 'Owner Private']);
$todo = Todo::factory()->recycle($owner)->for($shared)->create(['description' => 'Movable']);
$this->actingAs($member);
// The private target is not visible to the member at all.
expect(fn () => Livewire::test('pages::folders')->call('moveTodoToFolder', $todo->id, $privateTarget->id))
->toThrow(ModelNotFoundException::class);
$this->assertSame($shared->id, $todo->fresh()->folder_id);
});
+151
View File
@@ -0,0 +1,151 @@
<?php
use App\Mail\InvitationMail;
use App\Models\Invitation;
use App\Models\Organization;
use App\Models\User;
use App\OrganizationRole;
use App\WorkspaceType;
use Illuminate\Support\Facades\Mail;
use Livewire\Livewire;
/**
* Create a family workspace owned by the given user and make it their active
* workspace.
*/
function membersWorkspaceFor(User $owner): Organization
{
$organization = Organization::factory()->family()->withMember($owner)->create();
$owner->forceFill(['current_organization_id' => $organization->id])->save();
return $organization;
}
test('a workspace admin can invite a member by email', function () {
Mail::fake();
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
$this->actingAs($owner);
Livewire::test('pages::workspace.members')
->set('inviteEmail', 'Invitee@example.com')
->set('inviteRole', OrganizationRole::Member->value)
->call('inviteMember')
->assertHasNoErrors();
$this->assertDatabaseHas('invitations', [
'inviteable_type' => Organization::class,
'inviteable_id' => $organization->id,
'email' => 'invitee@example.com',
'role' => OrganizationRole::Member->value,
]);
Mail::assertSent(InvitationMail::class);
});
test('a full family workspace refuses new member invitations', function () {
Mail::fake();
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
for ($i = 0; $i < 5; $i++) {
$organization->users()->attach(User::factory()->create(), ['role' => OrganizationRole::Member->value]);
}
$this->actingAs($owner);
Livewire::test('pages::workspace.members')
->set('inviteEmail', 'overflow@example.com')
->call('inviteMember')
->assertHasErrors('inviteEmail')
->assertSeeHtml('data-test="workspace-full-notice"');
$this->assertDatabaseCount('invitations', 0);
Mail::assertNothingSent();
});
test('a workspace admin can change a member role and remove them', function () {
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
$member = User::factory()->create();
$organization->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$this->actingAs($owner);
Livewire::test('pages::workspace.members')
->set('memberRoles.'.$member->id, OrganizationRole::Admin->value)
->assertHasNoErrors();
expect($organization->userHasRole($member->fresh(), OrganizationRole::Admin))->toBeTrue();
Livewire::test('pages::workspace.members')
->call('removeMember', $member->id);
expect($organization->users()->where('users.id', $member->id)->exists())->toBeFalse();
});
test('removing a member moves them back to their personal workspace', function () {
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
$member = User::factory()->create();
$organization->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$member->forceFill(['current_organization_id' => $organization->id])->save();
$this->actingAs($owner);
Livewire::test('pages::workspace.members')->call('removeMember', $member->id);
$personal = $member->fresh()->currentOrganization()->first();
expect($personal)->not->toBeNull();
expect($personal->type)->toBe(WorkspaceType::Personal);
});
test('the owner cannot be removed', function () {
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
$this->actingAs($owner);
Livewire::test('pages::workspace.members')->call('removeMember', $owner->id);
expect($organization->users()->where('users.id', $owner->id)->exists())->toBeTrue();
});
test('a workspace admin can revoke a pending invitation', function () {
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
$invitation = Invitation::factory()->forOrganization($organization)->create(['inviter_id' => $owner->id]);
$this->actingAs($owner);
Livewire::test('pages::workspace.members')
->call('revokeInvitation', $invitation->id);
$this->assertDatabaseMissing('invitations', ['id' => $invitation->id]);
});
test('a plain member sees the member list but cannot manage it', function () {
$owner = User::factory()->create();
$organization = membersWorkspaceFor($owner);
$member = User::factory()->create(['name' => 'Plain Member']);
$organization->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$member->forceFill(['current_organization_id' => $organization->id])->save();
$this->actingAs($member);
Livewire::test('pages::workspace.members')
->assertSee('Plain Member')
->assertDontSeeHtml('data-test="invite-member-button"')
->assertDontSeeHtml('data-test="remove-member-'.$owner->id.'"');
Livewire::test('pages::workspace.members')
->set('inviteEmail', 'sneaky@example.com')
->call('inviteMember')
->assertStatus(403);
$this->assertDatabaseCount('invitations', 0);
});
+141
View File
@@ -0,0 +1,141 @@
<?php
use App\Models\Organization;
use App\Models\User;
use App\OrganizationRole;
use App\WorkspaceType;
use Illuminate\Support\Facades\Schema;
test('folder and todo workspace ids are enforced as not nullable', function () {
$folderColumn = collect(Schema::getColumns('folders'))->firstWhere('name', 'organization_id');
$todoColumn = collect(Schema::getColumns('todos'))->firstWhere('name', 'organization_id');
expect($folderColumn['nullable'])->toBeFalse();
expect($todoColumn['nullable'])->toBeFalse();
});
test('organization workspaces default to the organization type', function () {
$org = Organization::factory()->create();
expect($org->type)->toBe(WorkspaceType::Organization);
});
test('the personal factory state marks a personal workspace', function () {
$org = Organization::factory()->personal()->create();
expect($org->type)->toBe(WorkspaceType::Personal);
expect($org->personal_workspace)->toBeTrue();
});
test('the family factory state marks a family workspace', function () {
$org = Organization::factory()->family()->create();
expect($org->type)->toBe(WorkspaceType::Family);
expect($org->isFamily())->toBeTrue();
});
test('seat limits cap personal and family workspaces but not organizations', function () {
expect(Organization::factory()->personal()->create()->seatLimit())->toBe(1);
expect(Organization::factory()->family()->create()->seatLimit())->toBe(6);
expect(Organization::factory()->create()->seatLimit())->toBeNull();
});
test('a workspace at its seat limit cannot accept another member', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
for ($i = 0; $i < 5; $i++) {
$org->users()->attach(User::factory()->create(), ['role' => OrganizationRole::Member->value]);
}
expect($org->canAddMember())->toBeFalse();
});
test('organization workspaces never hit a seat limit', function () {
$owner = User::factory()->create();
$org = Organization::factory()->create();
$org->users()->attach($owner, ['role' => OrganizationRole::Owner->value]);
expect($org->seatLimit())->toBeNull();
expect($org->canAddMember())->toBeTrue();
});
test('workspace members and admins are counted by memberCount', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
$org->users()->attach(User::factory()->create(), ['role' => OrganizationRole::Member->value]);
expect($org->memberCount())->toBe(2);
});
test('only workspace admins manage members and billing', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
$admin = User::factory()->create();
$org->users()->attach($admin, ['role' => OrganizationRole::Admin->value]);
$member = User::factory()->create();
$org->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$this->actingAs($member);
expect($member->can('manageMembers', $org))->toBeFalse();
expect($member->can('manageBilling', $org))->toBeFalse();
expect($member->can('update', $org))->toBeFalse();
$this->actingAs($admin);
expect($admin->can('manageMembers', $org))->toBeTrue();
expect($admin->can('manageBilling', $org))->toBeTrue();
});
test('owners and admins are organization admins while members and strangers are not', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
$admin = User::factory()->create();
$org->users()->attach($admin, ['role' => OrganizationRole::Admin->value]);
$member = User::factory()->create();
$org->users()->attach($member, ['role' => OrganizationRole::Member->value]);
$stranger = User::factory()->create();
expect($owner->isOrganizationAdmin($org))->toBeTrue()
->and($admin->isOrganizationAdmin($org))->toBeTrue()
->and($member->isOrganizationAdmin($org))->toBeFalse()
->and($stranger->isOrganizationAdmin($org))->toBeFalse();
});
test('a site admin is not an organization admin of a workspace they do not belong to', function () {
$siteAdmin = User::factory()->asAdmin()->create();
$org = Organization::factory()->family()->withMember(User::factory()->create())->create();
expect($siteAdmin->isSiteAdmin())->toBeTrue()
->and($siteAdmin->isOrganizationAdmin($org))->toBeFalse();
});
test('only the owner can delete a workspace', function () {
$owner = User::factory()->create();
$org = Organization::factory()->family()->withMember($owner)->create();
$admin = User::factory()->create();
$org->users()->attach($admin, ['role' => OrganizationRole::Admin->value]);
$this->actingAs($admin);
expect($admin->can('delete', $org))->toBeFalse();
$this->actingAs($owner);
expect($owner->can('delete', $org))->toBeTrue();
});
test('strangers cannot view a workspace', function () {
$org = Organization::factory()->create();
$stranger = User::factory()->create();
$this->actingAs($stranger);
expect($stranger->can('view', $org))->toBeFalse();
});
test('users get a personal organization when created', function () {
$user = User::factory()->create();
expect($user->current_organization_id)->not->toBeNull();
$org = $user->currentOrganization()->first();
expect($org->type)->toBe(WorkspaceType::Personal);
expect($org->isPersonal())->toBeTrue();
expect($user->organizations()->wherePivot('role', OrganizationRole::Owner->value)->count())->toBe(1);
});