277 lines
11 KiB
PHP
277 lines
11 KiB
PHP
<?php
|
|
|
|
use App\FolderRole;
|
|
use App\FolderVisibility;
|
|
use App\Models\Folder;
|
|
use App\Models\Organization;
|
|
use App\Models\Todo;
|
|
use App\Models\User;
|
|
use App\OrganizationRole;
|
|
|
|
function familyWorkspace(User $owner): Organization
|
|
{
|
|
$org = Organization::factory()->family()->withMember($owner)->create();
|
|
$owner->forceFill(['current_organization_id' => $org->id])->save();
|
|
|
|
return $org;
|
|
}
|
|
|
|
function addWorkspaceMember(Organization $org, User $user, OrganizationRole $role = OrganizationRole::Member): void
|
|
{
|
|
$org->users()->attach($user, ['role' => $role->value]);
|
|
}
|
|
|
|
test('the folder creating hook assigns the owner workspace and personal folders stay private', function () {
|
|
$user = User::factory()->create();
|
|
|
|
$folder = Folder::factory()->for($user)->create(['name' => 'Personal Project']);
|
|
|
|
expect($folder->organization_id)->toBe($user->current_organization_id);
|
|
expect($folder->visibility)->toBe(FolderVisibility::Private);
|
|
});
|
|
|
|
test('folders in a family workspace default to workspace visibility', function () {
|
|
$owner = User::factory()->create();
|
|
familyWorkspace($owner);
|
|
|
|
$folder = Folder::factory()->for($owner)->create(['name' => 'Shared List']);
|
|
|
|
expect($folder->organization_id)->toBe($owner->current_organization_id);
|
|
expect($folder->visibility)->toBe(FolderVisibility::Workspace);
|
|
});
|
|
|
|
test('the todo creating hook inherits the workspace of its folder', function () {
|
|
$user = User::factory()->create();
|
|
$folder = Folder::factory()->for($user)->create(['name' => 'Work']);
|
|
|
|
$todo = Todo::factory()->for($folder)->create(['description' => 'A task']);
|
|
|
|
expect($todo->organization_id)->toBe($folder->organization_id);
|
|
});
|
|
|
|
test('the folder owner holds admin on their own folder', function () {
|
|
$owner = User::factory()->create();
|
|
$folder = Folder::factory()->for($owner)->create(['name' => 'Mine']);
|
|
|
|
expect($folder->effectiveRoleFor($owner))->toBe(FolderRole::Admin);
|
|
});
|
|
|
|
test('a workspace member sees workspace folders as a viewer', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
|
|
expect($folder->effectiveRoleFor($member))->toBe(FolderRole::Viewer);
|
|
});
|
|
|
|
test('a workspace admin holds admin on workspace folders', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$admin = User::factory()->create();
|
|
addWorkspaceMember($org, $admin, OrganizationRole::Admin);
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
|
|
expect($folder->effectiveRoleFor($admin))->toBe(FolderRole::Admin);
|
|
});
|
|
|
|
test('an explicit share grants the shared role on a private folder', function () {
|
|
$owner = User::factory()->create();
|
|
$member = User::factory()->create();
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Private']);
|
|
|
|
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
|
|
|
|
expect($folder->effectiveRoleFor($member))->toBe(FolderRole::Editor);
|
|
});
|
|
|
|
test('the strongest of overlapping roles wins', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
|
|
|
|
expect($folder->effectiveRoleFor($member))->toBe(FolderRole::Editor);
|
|
});
|
|
|
|
test('a workspace member cannot access a private folder', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Private']);
|
|
|
|
expect($folder->effectiveRoleFor($member))->toBeNull();
|
|
});
|
|
|
|
test('a share on a parent folder cascades to its descendants', function () {
|
|
$owner = User::factory()->create();
|
|
$member = User::factory()->create();
|
|
|
|
$parent = Folder::factory()->for($owner)->private()->create(['name' => 'Parent']);
|
|
$child = Folder::factory()->childOf($parent)->private()->create(['name' => 'Child']);
|
|
|
|
$parent->shares()->attach($member, ['role' => FolderRole::Editor->value]);
|
|
|
|
expect($parent->effectiveRoleFor($member))->toBe(FolderRole::Editor);
|
|
expect($child->effectiveRoleFor($member))->toBe(FolderRole::Editor);
|
|
});
|
|
|
|
test('a private folder drops out of inherited workspace access', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
|
|
$parent = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Parent']);
|
|
$child = Folder::factory()->childOf($parent)->private()->create(['name' => 'Private Child']);
|
|
|
|
expect($parent->effectiveRoleFor($member))->toBe(FolderRole::Viewer);
|
|
expect($child->effectiveRoleFor($member))->toBeNull();
|
|
});
|
|
|
|
test('the visibleTo scope covers workspace folders and excludes strangers', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
$stranger = User::factory()->create();
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
|
|
expect(Folder::query()->visibleTo($member)->pluck('id'))->toContain($folder->id);
|
|
expect(Folder::query()->visibleTo($stranger)->pluck('id'))->not->toContain($folder->id);
|
|
});
|
|
|
|
test('the visibleTo scope includes folders shared with the user anywhere', function () {
|
|
$owner = User::factory()->create();
|
|
$member = User::factory()->create();
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Shared With Me']);
|
|
$stranger = User::factory()->create();
|
|
|
|
$folder->shares()->attach($member, ['role' => FolderRole::Editor->value]);
|
|
|
|
expect(Folder::query()->visibleTo($member)->pluck('id'))->toContain($folder->id);
|
|
expect(Folder::query()->visibleTo($stranger)->pluck('id'))->not->toContain($folder->id);
|
|
});
|
|
|
|
test('todo visibility follows the folder access', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
$stranger = User::factory()->create();
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
$todo = Todo::factory()->for($folder)->create(['description' => 'Shared task']);
|
|
|
|
expect(Todo::query()->visibleTo($member)->pluck('id'))->toContain($todo->id);
|
|
expect(Todo::query()->visibleTo($stranger)->pluck('id'))->not->toContain($todo->id);
|
|
});
|
|
|
|
test('workspace members can view workspace folders', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
|
|
$this->actingAs($member);
|
|
expect($member->can('view', $folder))->toBeTrue();
|
|
});
|
|
|
|
test('strangers cannot view folders they have no role on', function () {
|
|
$owner = User::factory()->create();
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Private']);
|
|
$stranger = User::factory()->create();
|
|
|
|
$this->actingAs($stranger);
|
|
expect($stranger->can('view', $folder))->toBeFalse();
|
|
});
|
|
|
|
test('viewers cannot rename a folder', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
|
|
$folder = Folder::factory()->for($owner)->sharedWithWorkspace()->create(['name' => 'Shared']);
|
|
|
|
$this->actingAs($member);
|
|
expect($member->can('update', $folder))->toBeFalse();
|
|
});
|
|
|
|
test('a folder admin can share a folder and create folders beneath it', function () {
|
|
$owner = User::factory()->create();
|
|
$admin = User::factory()->create();
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Dir']);
|
|
|
|
$folder->shares()->attach($admin, ['role' => FolderRole::Admin->value]);
|
|
|
|
$this->actingAs($admin);
|
|
expect($admin->can('manageShares', $folder))->toBeTrue();
|
|
expect($admin->can('createChild', $folder))->toBeTrue();
|
|
});
|
|
|
|
test('only workspace admins create top-level folders', function () {
|
|
$owner = User::factory()->create();
|
|
$org = familyWorkspace($owner);
|
|
$member = User::factory()->create();
|
|
addWorkspaceMember($org, $member);
|
|
$workspaceAdmin = User::factory()->create();
|
|
addWorkspaceMember($org, $workspaceAdmin, OrganizationRole::Admin);
|
|
|
|
$this->actingAs($member);
|
|
expect($member->can('create', [Folder::class, $org]))->toBeFalse();
|
|
|
|
$this->actingAs($workspaceAdmin);
|
|
expect($workspaceAdmin->can('create', [Folder::class, $org]))->toBeTrue();
|
|
});
|
|
|
|
test('editors can add and edit todos while markers only mark complete', function () {
|
|
$owner = User::factory()->create();
|
|
$editor = User::factory()->create();
|
|
$marker = User::factory()->create();
|
|
$viewer = User::factory()->create();
|
|
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Dir']);
|
|
$folder->shares()->attach($editor, ['role' => FolderRole::Editor->value]);
|
|
$folder->shares()->attach($marker, ['role' => FolderRole::Marker->value]);
|
|
$folder->shares()->attach($viewer, ['role' => FolderRole::Viewer->value]);
|
|
|
|
$todo = Todo::factory()->for($folder)->create(['description' => 'A task']);
|
|
|
|
$this->actingAs($editor);
|
|
expect($editor->can('create', [Todo::class, $folder]))->toBeTrue();
|
|
expect($editor->can('update', $todo))->toBeTrue();
|
|
|
|
$this->actingAs($marker);
|
|
expect($marker->can('create', [Todo::class, $folder]))->toBeFalse();
|
|
expect($marker->can('update', $todo))->toBeFalse();
|
|
expect($marker->can('markComplete', $todo))->toBeTrue();
|
|
|
|
$this->actingAs($viewer);
|
|
expect($viewer->can('markComplete', $todo))->toBeFalse();
|
|
});
|
|
|
|
test('strangers cannot touch todos in a folder', function () {
|
|
$owner = User::factory()->create();
|
|
$folder = Folder::factory()->for($owner)->private()->create(['name' => 'Dir']);
|
|
$todo = Todo::factory()->for($folder)->create(['description' => 'A task']);
|
|
$stranger = User::factory()->create();
|
|
|
|
$this->actingAs($stranger);
|
|
expect($stranger->can('view', $todo))->toBeFalse();
|
|
expect($stranger->can('update', $todo))->toBeFalse();
|
|
expect($stranger->can('delete', $todo))->toBeFalse();
|
|
expect($stranger->can('markComplete', $todo))->toBeFalse();
|
|
});
|